Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

88 add clowder connection containers back to the docker compose #89

Merged
merged 15 commits into from
Jan 18, 2024
Merged

88 add clowder connection containers back to the docker compose #89

merged 15 commits into from
Jan 18, 2024

Conversation

longshuicy
Copy link
Member

@longshuicy longshuicy commented Nov 27, 2023 •
edited
Loading

To Test:

  • on smm-tester, run sh docker-command-smile-traefik.sh.
  • I already added the clowder yml file as well as update the docker-compose start part of the shell script

A few highlights

  • I fixed every image to be latest since docker-compose script will not be updated very often
  • Updated the depend_on to make everything more independent
  • There was a bug, fixed from
MINIO_PUBLIC_ACCESS_URL=${MINIO_URL}

to

 - MINIO_PUBLIC_ACCESS_URL=${MINIO_PUBLIC_ACCESS_URL}
  • Another bug
- AWS_ACCESSKEY=${MINIO_ROOT_USER}
- AWS_ACCESSKEYSECRET=${MINIO_ROOT_PASSWORD}

to

- AWS_ACCESSKEY=${AWS_ACCESSKEY}
- AWS_ACCESSKEYSECRET=${AWS_ACCESSKEYSECRET}
  • missing newly added environment variable added, such as TWITTER_ON etc..
  • Update the original docker-compose yaml as well

@longshuicy longshuicy linked an issue Nov 27, 2023 that may be closed by this pull request
Add Clowder connection containers back to the docker compose #88
Closed
@longshuicy longshuicy marked this pull request as ready for review November 27, 2023 21:17
@longshuicy longshuicy requested a review from ywkim312 November 27, 2023 21:40
@longshuicy longshuicy requested a review from ywkim312 January 11, 2024 18:49
@ywkim312
Copy link
Collaborator

I keeping having trouble running docker-compose-smile-traefik. Would you try to run this and let me know if it works okay for you?

@longshuicy
Copy link
Member Author

I keeping having trouble running docker-compose-smile-traefik. Would you try to run this and let me know if it works okay for you?

There is a bug on passing the correct RabbitMQ username and host in addressed in this merged PR: https://github.com/ncsa/standalone-smm-analytics/pull/91/files.

To make it work, I changed relevant images tag to pr-91 which is that PR. Everything should work on the smm-tester now. But as for this PR since we would like to release soon, I kept them "latest".

@ywkim312
Copy link
Collaborator

It worked to launch the site on smm-tester. However, when I uploaded the result to clowder, it went to clowder.smm.ncsa.illinois.edu. How to check the clowder in smm-tester?

@ywkim312 ywkim312 merged commit 72f7d96 into develop Jan 18, 2024
20 checks passed
@ywkim312 ywkim312 deleted the 88-add-clowder-connection-containers-back-to-the-docker-compose branch January 18, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywkim312 ywkim312 ywkim312 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Clowder connection containers back to the docker compose
2 participants
@longshuicy @ywkim312